Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/2131#discussion_r68409807
--- Diff:
flink-streaming-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/model/KinesisStreamShard.java
---
@@ -61,19 +68,23 @@ public String getShardId() {
}
public String getStartingSequenceNumber() {
- return
shard.getSequenceNumberRange().getStartingSequenceNumber();
+ SequenceNumberRange sequenceNumberRange =
shard.getSequenceNumberRange();
+ return (sequenceNumberRange == null) ? null :
sequenceNumberRange.getStartingSequenceNumber();
--- End diff --
I added these null checks because in the tests, fake `KinesisStreamShards`
may be created without giving them a SequenceNumberRange / HashNumberRange etc.
if it wasn't relevant to the test. Perhaps I should revert these null check
changes, and always give all values for the fake `KinesisStreamShard`s?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
