Github user tzulitai commented on a diff in the pull request:

    https://github.com/apache/flink/pull/2131#discussion_r68412025
  
    --- Diff: 
flink-streaming-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/proxy/KinesisProxy.java
 ---
    @@ -206,4 +287,9 @@ private DescribeStreamResult describeStream(String 
streamName, String startShard
                        throw new RuntimeException("Stream is not Active or 
Updating");
    --- End diff --
    
    Actually, should we really be throwing a RuntimeException if a single 
stream is not in ACTIVE or UPDATING status? Say the consumer is to fetch 3 
streams, and only 1 is found to be CREATING / DELETING. Perhaps we should treat 
this case the same as "can only find shards for some of the streams", and a 
warning log here will do?
    
    There's a check that stops the consumer in the new `ShardDiscoverer` if no 
shards can be initially found at all to read from anyway.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to