[ 
https://issues.apache.org/jira/browse/FLINK-1550?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15352889#comment-15352889
 ] 

ASF GitHub Bot commented on FLINK-1550:
---------------------------------------

Github user tillrohrmann commented on a diff in the pull request:

    https://github.com/apache/flink/pull/2146#discussion_r68744357
  
    --- Diff: 
flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/CheckpointCoordinator.java
 ---
    @@ -663,6 +677,9 @@ public boolean 
receiveAcknowledgeMessage(AcknowledgeCheckpoint message) throws E
                                                LOG.info("Completed checkpoint 
" + checkpointId + " (in " +
                                                                
completed.getDuration() + " ms)");
     
    +                                           lastCheckpointSize = 
completed.getStateSize();
    +                                           lastCheckpointDuration = 
completed.getDuration();
    --- End diff --
    
    Would it make sense to use the `CheckpointStatsTracker` to obtain the 
values for the last checkpoint? Given that the JobManager is not so high 
performance critical with respect to the calculation of the metrics.


> Show JVM Metrics for JobManager
> -------------------------------
>
>                 Key: FLINK-1550
>                 URL: https://issues.apache.org/jira/browse/FLINK-1550
>             Project: Flink
>          Issue Type: Sub-task
>          Components: JobManager, Metrics
>            Reporter: Robert Metzger
>            Assignee: Chesnay Schepler
>             Fix For: pre-apache
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to