[ 
https://issues.apache.org/jira/browse/FLINK-1550?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15354874#comment-15354874
 ] 

ASF GitHub Bot commented on FLINK-1550:
---------------------------------------

Github user zentol commented on a diff in the pull request:

    https://github.com/apache/flink/pull/2146#discussion_r68914059
  
    --- Diff: 
flink-runtime/src/main/scala/org/apache/flink/runtime/jobmanager/JobManager.scala
 ---
    @@ -1235,7 +1234,7 @@ class JobManager(
                     ConfigConstants.JOB_MANAGER_WEB_CHECKPOINTS_HISTORY_SIZE,
                     
ConfigConstants.DEFAULT_JOB_MANAGER_WEB_CHECKPOINTS_HISTORY_SIZE)
     
    -              new SimpleCheckpointStatsTracker(historySize, ackVertices)
    +              new SimpleCheckpointStatsTracker(historySize, ackVertices, 
jobMetrics)
    --- End diff --
    
    JobManager.scala, line 1664.
    
    I would also create it regardless of the Tracker. The moment we use it in 
another component we would have to move it out of that condition anyways.


> Show JVM Metrics for JobManager
> -------------------------------
>
>                 Key: FLINK-1550
>                 URL: https://issues.apache.org/jira/browse/FLINK-1550
>             Project: Flink
>          Issue Type: Sub-task
>          Components: JobManager, Metrics
>            Reporter: Robert Metzger
>            Assignee: Chesnay Schepler
>             Fix For: pre-apache
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to