[
https://issues.apache.org/jira/browse/FLINK-4084?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15354850#comment-15354850
]
ASF GitHub Bot commented on FLINK-4084:
---------------------------------------
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2149#discussion_r68910391
--- Diff:
flink-clients/src/main/java/org/apache/flink/client/CliFrontend.java ---
@@ -132,9 +132,9 @@
- private final Configuration config;
+ private Configuration config;
--- End diff --
Could we make the `configDir` parameter a general parameter that goes
before `run`, `list`, `cancel`, etc.? Don't know if that is too tricky but it
would make sense because it is a general configuration key.
`flink --configDir /my/custom/dir run -p 10 /path/to/jar`
That way the config parameter wouldn't have to be listed for every action.
Would make the help look less verbose.
You could parse the config parameter in the constructor and initialize the
config only once. Then continue with the normal parsing.
> Add configDir parameter to CliFrontend and flink shell script
> -------------------------------------------------------------
>
> Key: FLINK-4084
> URL: https://issues.apache.org/jira/browse/FLINK-4084
> Project: Flink
> Issue Type: Improvement
> Components: Client
> Affects Versions: 1.1.0
> Reporter: Till Rohrmann
> Assignee: Andrea Sella
> Priority: Minor
>
> At the moment there is no other way than the environment variable
> FLINK_CONF_DIR to specify the configuration directory for the CliFrontend if
> it is started via the flink shell script. In order to improve the user
> exprience, I would propose to introduce a {{--configDir}} parameter which the
> user can use to specify a configuration directory more easily.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
