[
https://issues.apache.org/jira/browse/FLINK-4084?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15352847#comment-15352847
]
ASF GitHub Bot commented on FLINK-4084:
---------------------------------------
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2149#discussion_r68741918
--- Diff:
flink-clients/src/test/java/org/apache/flink/client/CliFrontendRunTest.java ---
@@ -100,15 +100,22 @@ public void testRun() {
}
// test jar arguments
+ {
+ String[] parameters =
+ {"-m", "localhost:6123", getTestJarPath(),
"-arg1", "value1", "justavalue", "--arg2", "value2"};
+ RunOptions options =
CliFrontendParser.parseRunCommand(parameters);
+ assertEquals("-arg1", options.getProgramArgs()[0]);
+ assertEquals("value1", options.getProgramArgs()[1]);
+ assertEquals("justavalue", options.getProgramArgs()[2]);
+ assertEquals("--arg2", options.getProgramArgs()[3]);
+ assertEquals("value2", options.getProgramArgs()[4]);
--- End diff --
Tabs have been converted to spaces here. That's why the diff looks odd.
Please use tabs for indention.
> Add configDir parameter to CliFrontend and flink shell script
> -------------------------------------------------------------
>
> Key: FLINK-4084
> URL: https://issues.apache.org/jira/browse/FLINK-4084
> Project: Flink
> Issue Type: Improvement
> Components: Client
> Affects Versions: 1.1.0
> Reporter: Till Rohrmann
> Assignee: Andrea Sella
> Priority: Minor
>
> At the moment there is no other way than the environment variable
> FLINK_CONF_DIR to specify the configuration directory for the CliFrontend if
> it is started via the flink shell script. In order to improve the user
> exprience, I would propose to introduce a {{--configDir}} parameter which the
> user can use to specify a configuration directory more easily.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
