akalash commented on a change in pull request #17663:
URL: https://github.com/apache/flink/pull/17663#discussion_r742742833
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/LocalInputChannel.java
##########
@@ -338,10 +338,13 @@ void releaseAllResources() throws IOException {
@Override
void announceBufferSize(int newBufferSize) {
- checkState(!isReleased, "Channel released.");
-
- ResultSubpartitionView subpartitionView =
checkNotNull(this.subpartitionView);
- subpartitionView.notifyNewBufferSize(newBufferSize);
+ ResultSubpartitionView view = this.subpartitionView;
+ // if releaseAllResources would be called from the mailbox thread it
is possible that
Review comment:
Maybe I don't fully understand the problem about finished
`SingleInputGate`, but as I understand after this ticket we will just send
nothing to already finished channels. So it should work totally fine.
Or is your question about how correctly can we calculate buffer size if some
of the gates would be finished? ( I actually think it should also work
especially after your ticket about multiply gates)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
