akalash commented on a change in pull request #17663:
URL: https://github.com/apache/flink/pull/17663#discussion_r742749519
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/LocalInputChannel.java
##########
@@ -338,10 +338,13 @@ void releaseAllResources() throws IOException {
@Override
void announceBufferSize(int newBufferSize) {
- checkState(!isReleased, "Channel released.");
-
- ResultSubpartitionView subpartitionView =
checkNotNull(this.subpartitionView);
- subpartitionView.notifyNewBufferSize(newBufferSize);
+ ResultSubpartitionView view = this.subpartitionView;
Review comment:
yes, I guess I can but in this case, I will need to double-check
subpartitinView for null because if `releaseAllResources` and
`announceBufferSize` will be called in parallel it will be a problem. I know
that logically, it is impossible right now to execute these methods in parallel
but anyway we don't have such explicit restrictions in the code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
