Airblader commented on a change in pull request #17698:
URL: https://github.com/apache/flink/pull/17698#discussion_r744457632
##########
File path:
flink-runtime-web/web-dashboard/src/app/pages/task-manager/log-list/task-manager-log-list.component.html
##########
@@ -29,14 +29,16 @@
<thead>
<tr>
<th>Log Name</th>
- <th>Size (KB)</th>
+ <th [nzSortFn]="sortLastModifiedTimeFn">Last Modified Time</th>
+ <th [nzSortFn]="sortSizeFn">Size (KB)</th>
</tr>
</thead>
<tbody>
- <tr *ngFor="let log of listOfLog">
+ <tr *ngFor="let log of table.data">
Review comment:
I don't mean what the type "should" be, but rather what the Angular
Language Service will _actually_ infer. The last time I checked, Angular cannot
use component generics to infer the type correctly. You can hover over the
`log` in `let log` and see the type the language service will infer. If this is
`any`, that's not good.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
