ysymi commented on a change in pull request #17698:
URL: https://github.com/apache/flink/pull/17698#discussion_r744667872



##########
File path: 
flink-runtime-web/web-dashboard/src/app/pages/task-manager/log-list/task-manager-log-list.component.html
##########
@@ -29,14 +29,16 @@
     <thead>
       <tr>
         <th>Log Name</th>
-        <th>Size (KB)</th>
+        <th [nzSortFn]="sortLastModifiedTimeFn">Last Modified Time</th>
+        <th [nzSortFn]="sortSizeFn">Size (KB)</th>
       </tr>
     </thead>
     <tbody>
-      <tr *ngFor="let log of listOfLog">
+      <tr *ngFor="let log of table.data">

Review comment:
       I got it and I found that the type of `log` in  `let log in table.data` 
is `unknown` and  type of `table.data` is `unknown[]` by the way you said in 
IDE. I should change it to `let log in listOfLog` and then type of `log` will 
be clear and correct, am I right ? @Airblader      




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to