tillrohrmann commented on a change in pull request #17693:
URL: https://github.com/apache/flink/pull/17693#discussion_r745470980
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/PendingCheckpoint.java
##########
@@ -336,6 +336,8 @@ public CompletedCheckpoint finalizeCheckpoint(
props,
finalizedLocation);
+ // Mark this pending checkpoint as disposed, but do NOT drop
the state.
+ dispose(false, checkpointsCleaner, postCleanup, executor);
Review comment:
Shouldn't we make sure that nothing uses/adds new things to clean up to
the `CheckpointsCleaner` before shutting it down? It seems like a brittle
contract that we need to place the `dispose` call at certain places in the code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
