dmvk commented on a change in pull request #17693:
URL: https://github.com/apache/flink/pull/17693#discussion_r745846216
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/PendingCheckpoint.java
##########
@@ -336,6 +336,8 @@ public CompletedCheckpoint finalizeCheckpoint(
props,
finalizedLocation);
+ // Mark this pending checkpoint as disposed, but do NOT drop
the state.
+ dispose(false, checkpointsCleaner, postCleanup, executor);
Review comment:
Aaaaaaa, I've finally got the missing piece 🤦 🤦
```java
final CompletableFuture<Void> checkpointServicesShutdownFuture =
CompletableFuture.allOf(
executionGraph
.getTerminationFuture()
.thenAcceptAsync(
this::shutDownCheckpointServices,
getMainThreadExecutor()),
checkpointsCleaner.closeAsync());
```
I've read this statement as "close the cleaner after the execution graph"
for the whole time
Now what you're suggesting finally starts making sense :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
