JingGe commented on a change in pull request #17995: URL: https://github.com/apache/flink/pull/17995#discussion_r761977252
########## File path: flink-runtime/src/main/java/org/apache/flink/runtime/dispatcher/ConfigurationNotAllowedError.java ########## @@ -0,0 +1,50 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.runtime.dispatcher; + +import org.apache.flink.annotation.Internal; + +/** + * If {@link org.apache.flink.configuration.DeploymentOptions#ALLOW_CLIENT_JOB_CONFIGURATIONS} is + * disabled this error denotes the not allowed configuration. + */ +@Internal +public class ConfigurationNotAllowedError implements JobValidationError { Review comment: The other way works too. I think there is no conflict. Flink and user jobs are in different scopes. Consider Flink as the platform and the job with user code is a piece of dynamic logic running on it. The unchecked exception mentioned here will only bring the dynamic logic piece to its knees within the scope of the user code. Flink plays the controller role outside of this scope to manage the exceptions and complete the dynamic logic(the job) and mark it as `FAILED`, in the meantime, Flink itself is still stable and healthy, i.e. any these kinds of unchecked exception will not effect Flink itself. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
