fapaul commented on a change in pull request #17995:
URL: https://github.com/apache/flink/pull/17995#discussion_r763001347
##########
File path:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/environment/StreamExecutionEnvironment.java
##########
@@ -2081,6 +2101,20 @@ public JobClient executeAsync(StreamGraph streamGraph)
throws Exception {
configuration.get(DeploymentOptions.TARGET),
"No execution.target specified in your configuration file.");
+ errors.addAll(checkNotAllowedConfigurations());
+ if (!errors.isEmpty()) {
+ // HACK: We shortcut the StreamGraph to jobgraph translation
because we already
+ // know that the job needs to fail and can derive the jobId.
+
+ final JobID jobId =
+ configuration
+
.getOptional(PipelineOptionsInternal.PIPELINE_FIXED_JOB_ID)
+ .map(JobID::fromHexString)
+ .orElse(new JobID());
Review comment:
I checked all production cases accessing the `PIPELINE_FIXED_JOB_ID`
field and they all handle the return value of the optional differently.
Unfortunately, I do not see an easy way to duplicate things without making
deeper changes to when and where we generate the jobId.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
