fapaul commented on a change in pull request #17995:
URL: https://github.com/apache/flink/pull/17995#discussion_r763008949
##########
File path:
flink-clients/src/main/java/org/apache/flink/client/program/StreamContextEnvironment.java
##########
@@ -161,6 +189,16 @@ public static void setAsContext(
final boolean suppressSysout) {
StreamExecutionEnvironmentFactory factory =
conf -> {
+ final List<JobValidationError> errors = new ArrayList<>();
+ final boolean allowConfigurations =
+ configuration.getBoolean(
+
DeploymentOptions.ALLOW_CLIENT_JOB_CONFIGURATIONS);
+ if (!allowConfigurations && !conf.toMap().isEmpty()) {
+ conf.toMap()
+ .forEach(
+ (k, v) ->
+ errors.add(new
ConfigurationNotAllowedError(k, v)));
Review comment:
As a user, I would like to see all the configurations I am currently
using which are not allowed. If we only show a generic message it might be hard
to find the cause.
Is this what you mean?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
