Github user aljoscha commented on the issue:
https://github.com/apache/flink/pull/2269
Very good work!
I know we discussed before whether to check for inactivity in a different
thread or in `invoke()`. There's actually a third option that I'm showcasing in
the PR I did against your PR. ð The StreamTask already has a TimerService
that can be set for testing. If we use the appropriate methods in the bucketing
sink then we get testability with a settable clock for free.
I also added a `BucketSinkTest`. It think it would be good if the
`BucketSinkITCase` and `BucketingSinkMultipleActiveBucketsCase` could be folded
into this one because having the ITCases means having a lot of overhead and our
build is already taking quite long.
What do you think?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
