[
https://issues.apache.org/jira/browse/FLINK-4210?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15389494#comment-15389494
]
ASF GitHub Bot commented on FLINK-4210:
---------------------------------------
GitHub user zentol opened a pull request:
https://github.com/apache/flink/pull/2286
[FLINK-4210][metrics] Move close()/isClosed() out of MetricGroup
This PR moves the `close()` and `isClosed()` methods from the MetricGroup
interface into the AbstractMetricGroup class.
The reasoning is that users generally shouldn't need to call it, reporters
shouldn't be able to call it, and that several MetricGroup implementations
don't implement the method anyway.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/zentol/flink 4210_minus-close
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/2286.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2286
----
commit dc6e51be321eb46253100995c2b1fcc58f53aaf7
Author: zentol <[email protected]>
Date: 2016-07-22T13:20:08Z
[FLINK-4210][metrics] Move close()/isClosed() oout of MetricGroup
----
> Move close()/isClosed() out of MetricGroup interface
> ----------------------------------------------------
>
> Key: FLINK-4210
> URL: https://issues.apache.org/jira/browse/FLINK-4210
> Project: Flink
> Issue Type: Improvement
> Components: Metrics
> Affects Versions: 1.1.0
> Reporter: Chesnay Schepler
> Assignee: Chesnay Schepler
> Priority: Minor
> Fix For: 1.1.0
>
>
> The (user-facing) MetricGroup interface currently exposes a close() and
> isClosed() method which generally users shouldn't need to call. They are an
> internal thing, and thus should be moved into the AbstractMetricGroup class.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
