[
https://issues.apache.org/jira/browse/FLINK-4210?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15393538#comment-15393538
]
ASF GitHub Bot commented on FLINK-4210:
---------------------------------------
Github user uce commented on a diff in the pull request:
https://github.com/apache/flink/pull/2286#discussion_r72217528
--- Diff:
flink-core/src/main/java/org/apache/flink/metrics/MetricGroup.java ---
@@ -37,25 +37,6 @@
public interface MetricGroup {
//
------------------------------------------------------------------------
- // Closing
- //
------------------------------------------------------------------------
-
- /**
- * Marks the group as closed.
- * Recursively unregisters all {@link Metric Metrics} contained in this
group.
- *
- * <p>Any metrics created after the call to this function will not be
registered in
- * the {@link MetricRegistry} and not be reported to any reporter (like
JMX).
- */
- void close();
--- End diff --
The class-level JavaDocs have a link to `close` that is broken now.
> Move close()/isClosed() out of MetricGroup interface
> ----------------------------------------------------
>
> Key: FLINK-4210
> URL: https://issues.apache.org/jira/browse/FLINK-4210
> Project: Flink
> Issue Type: Improvement
> Components: Metrics
> Affects Versions: 1.1.0
> Reporter: Chesnay Schepler
> Assignee: Chesnay Schepler
> Priority: Minor
> Fix For: 1.1.0
>
>
> The (user-facing) MetricGroup interface currently exposes a close() and
> isClosed() method which generally users shouldn't need to call. They are an
> internal thing, and thus should be moved into the AbstractMetricGroup class.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
