slinkydeveloper commented on a change in pull request #18290:
URL: https://github.com/apache/flink/pull/18290#discussion_r783263646
##########
File path:
flink-connectors/flink-connector-files/src/main/java/org/apache/flink/connector/file/table/FileSystemTableFactory.java
##########
@@ -79,9 +86,27 @@ public DynamicTableSource createDynamicTableSource(Context
context) {
@Override
public DynamicTableSink createDynamicTableSink(Context context) {
FactoryUtil.TableFactoryHelper helper =
FactoryUtil.createTableFactoryHelper(this, context);
+ helper.forwardOptions(
+ FileSystemConnectorOptions.PATH,
+ FileSystemConnectorOptions.PARTITION_DEFAULT_NAME,
+ FileSystemConnectorOptions.PARTITION_TIME_EXTRACTOR_KIND,
+ FileSystemConnectorOptions.PARTITION_TIME_EXTRACTOR_CLASS,
+
FileSystemConnectorOptions.PARTITION_TIME_EXTRACTOR_TIMESTAMP_PATTERN,
+ FileSystemConnectorOptions.SINK_ROLLING_POLICY_FILE_SIZE,
+
FileSystemConnectorOptions.SINK_ROLLING_POLICY_ROLLOVER_INTERVAL,
+ FileSystemConnectorOptions.SINK_ROLLING_POLICY_CHECK_INTERVAL,
+ FileSystemConnectorOptions.SINK_SHUFFLE_BY_PARTITION,
Review comment:
Shuffle by partition is a mistake, will revert it. But the rolling
policy sounds safe as it's just tuning the object `TableRollingPolicy`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
