slinkydeveloper commented on a change in pull request #18290:
URL: https://github.com/apache/flink/pull/18290#discussion_r783279489
##########
File path:
flink-connectors/flink-connector-hbase-1.4/src/main/java/org/apache/flink/connector/hbase1/HBase1DynamicTableFactory.java
##########
@@ -65,16 +65,23 @@
@Override
public DynamicTableSource createDynamicTableSource(Context context) {
TableFactoryHelper helper = createTableFactoryHelper(this, context);
+ helper.forwardOptions(
+ TABLE_NAME,
+ ZOOKEEPER_ZNODE_PARENT,
+ ZOOKEEPER_QUORUM,
+ NULL_STRING_LITERAL,
+ LOOKUP_ASYNC,
Review comment:
Seems like it's an hbase 1 option as well, as it's used in
`HBaseConnectorOptionsUtil#getHBaseLookupOptions`, used by the hbase 1
connector as well. Will add among optional options, as hbase 2
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
