lindong28 commented on a change in pull request #18397:
URL: https://github.com/apache/flink/pull/18397#discussion_r788868076
##########
File path:
flink-connectors/flink-connector-kafka/src/main/java/org/apache/flink/connector/kafka/source/reader/deserializer/KafkaRecordDeserializationSchema.java
##########
@@ -123,9 +121,8 @@ default void
open(DeserializationSchema.InitializationContext context) throws Ex
* @return A {@link KafkaRecordDeserializationSchema} that deserialize the
value with the given
* deserializer.
*/
- static <V, D extends Configurable & Deserializer<V>>
- KafkaRecordDeserializationSchema<V> valueOnly(
- Class<D> valueDeserializerClass, Map<String, String>
config) {
+ static <V, D extends Deserializer<V>> KafkaRecordDeserializationSchema<V>
valueOnly(
Review comment:
BTW, this method (prior to https://github.com/apache/flink/pull/15051)
was added in FLINK-18323. Jiangjie Qin, author of that PR, was pretty familiar
with Kafka. I believe he has good reason to add that method, which uses
`org.apache.kafka.common.Configurable.configure` instead of
`org.apache.kafka.common.serialization.Deserializer.configure`. And I guess the
reason is likely due to backward compatibility.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
