[ 
https://issues.apache.org/jira/browse/FLINK-4282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15406108#comment-15406108
 ] 

ASF GitHub Bot commented on FLINK-4282:
---------------------------------------

GitHub user aditivin opened a pull request:

    https://github.com/apache/flink/pull/2331

    [FLINK-4282] [streaming] Added an offset parameter for processing time 
window ass…

    Added offset parameter for the processing time window assigners:
    - ProcessingTimeSessionWindows
    - SlidingProcessingTimeWindows
    - TumblingProcessingTimeWindows
    
    The offset is an optional parameter that can be added while creating these 
classes, and it can be supplied as a long value or a TimeZone.
    
    Test cases for the change are present in WindowAssignerOffsetTest. There 
are tests for positive, negative and TimeZone offsets for each of the classes.
    
    All Travis CI jobs passed.
    
    I haven't done it for the event time window assigners yet - I can add that 
if this is all right.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/aditivin/flink FLINK-4282

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/2331.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2331
    
----
commit 6b57c17a7b207b9e862d14afcc7c890377113d77
Author: zentol <ches...@apache.org>
Date:   2016-07-22T15:50:10Z

    [FLINK-4282] Added an offset parameter for processing time window assigners

----


> Add Offset Parameter to WindowAssigners
> ---------------------------------------
>
>                 Key: FLINK-4282
>                 URL: https://issues.apache.org/jira/browse/FLINK-4282
>             Project: Flink
>          Issue Type: Improvement
>          Components: Streaming
>            Reporter: Aljoscha Krettek
>
> Currently, windows are always aligned to EPOCH, which basically means days 
> are aligned with GMT. This is somewhat problematic for people living in 
> different timezones.
> And offset parameter would allow to adapt the window assigner to the timezone.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to