[ 
https://issues.apache.org/jira/browse/FLINK-4282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15408877#comment-15408877
 ] 

ASF GitHub Bot commented on FLINK-4282:
---------------------------------------

Github user aditivin commented on the issue:

    https://github.com/apache/flink/pull/2333
  
    Hi,
    Only the relevant changes are now visible. Pasting the details from the 
previous pull request (#2331) here:
    
    Added offset parameter for the following processing time window assigners:
    ProcessingTimeSessionWindows
    SlidingProcessingTimeWindows
    TumblingProcessingTimeWindows
    
    The offset is an optional parameter that can be added while creating these 
classes, and it can be supplied as a long value or a TimeZone.
    
    Test cases for the change are present in WindowAssignerOffsetTest. There 
are tests for positive, negative and TimeZone offsets for each of the classes.
    All Travis CI jobs passed.
    I haven't done it for the event time window assigners yet - I can add that 
if this is all right.


> Add Offset Parameter to WindowAssigners
> ---------------------------------------
>
>                 Key: FLINK-4282
>                 URL: https://issues.apache.org/jira/browse/FLINK-4282
>             Project: Flink
>          Issue Type: Improvement
>          Components: Streaming
>            Reporter: Aljoscha Krettek
>
> Currently, windows are always aligned to EPOCH, which basically means days 
> are aligned with GMT. This is somewhat problematic for people living in 
> different timezones.
> And offset parameter would allow to adapt the window assigner to the timezone.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to