JingGe commented on a change in pull request #18612:
URL: https://github.com/apache/flink/pull/18612#discussion_r798561215
##########
File path:
flink-connectors/flink-connector-kafka/src/main/java/org/apache/flink/connector/kafka/sink/KafkaSink.java
##########
@@ -86,45 +85,48 @@
return new KafkaSinkBuilder<>();
}
+ @Internal
Review comment:
1. Why use @Internal? User should have no access to the implementation
class.
2. Are those @Internal @Override methods coming from the interface
`StatefulSink` and `TwoPhaseCommittingSink` designed to always be used
internallly which means every further connector impl, e.g. elastic, hbase, etc.
must mark them as @Internal too? Is it possible to mark them as @Internal at
the interface level to save the connector developer's effort and avoid
potential human mistakes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
