fapaul commented on a change in pull request #18612:
URL: https://github.com/apache/flink/pull/18612#discussion_r798727583



##########
File path: 
flink-connectors/flink-connector-kafka/src/main/java/org/apache/flink/connector/kafka/sink/KafkaSink.java
##########
@@ -57,7 +54,9 @@
  * @see KafkaSinkBuilder on how to construct a KafkaSink
  */
 @PublicEvolving
-public class KafkaSink<IN> implements Sink<IN, KafkaCommittable, 
KafkaWriterState, Void> {
+public class KafkaSink<IN>

Review comment:
       I do not think this makes sense here because the `KafkaSinkBuilder` 
returns the `KafkaSink` on `build()`.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to