[ 
https://issues.apache.org/jira/browse/FLINK-4253?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15413886#comment-15413886
 ] 

ASF GitHub Bot commented on FLINK-4253:
---------------------------------------

Github user ramkrish86 commented on a diff in the pull request:

    https://github.com/apache/flink/pull/2342#discussion_r74105158
  
    --- Diff: 
flink-runtime/src/test/scala/org/apache/flink/runtime/testingUtils/TestingUtils.scala
 ---
    @@ -502,7 +503,8 @@ object TestingUtils {
           configuration: Configuration)
       : ActorGateway = {
     
    -    configuration.setString(ConfigConstants.HIGH_AVAILABILITY, 
ConfigConstants.DEFAULT_HIGH_AVAILABILTY)
    +    configuration.setString(ConfigConstants.HIGH_AVAILABILITY,
    --- End diff --
    
    After wrapping here 
    `[INFO] force-shading ...................................... SUCCESS [ 
11.954 s]
    [INFO] flink .............................................. SUCCESS [01:01 
min]
    [INFO] flink-annotations .................................. SUCCESS [  
7.724 s]
    [INFO] flink-shaded-hadoop ................................ SUCCESS [  
0.364 s]
    [INFO] flink-shaded-hadoop2 ............................... SUCCESS [ 
15.982 s]
    [INFO] flink-shaded-include-yarn-tests .................... SUCCESS [ 
16.367 s]
    [INFO] flink-shaded-curator ............................... SUCCESS [  
0.278 s]
    [INFO] flink-shaded-curator-recipes ....................... SUCCESS [  
1.953 s]
    [INFO] flink-shaded-curator-test .......................... SUCCESS [  
0.738 s]
    [INFO] flink-metrics ...................................... SUCCESS [  
0.326 s]
    [INFO] flink-metrics-core ................................. SUCCESS [  
8.961 s]
    [INFO] flink-test-utils-parent ............................ SUCCESS [  
0.302 s]
    [INFO] flink-test-utils-junit ............................. SUCCESS [  
7.145 s]
    [INFO] flink-core ......................................... SUCCESS [01:27 
min]
    [INFO] flink-java ......................................... SUCCESS [01:03 
min]
    [INFO] flink-runtime ...................................... SUCCESS [03:31 
min]
    [INFO] flink-optimizer .................................... SUCCESS [ 
43.211 s]
    [INFO] flink-clients ...................................... SUCCESS [ 
33.062 s]
    [INFO] flink-streaming-java ............................... SUCCESS [01:11 
min]
    [INFO] flink-test-utils ................................... SUCCESS [ 
29.337 s]
    [INFO] flink-scala ........................................ SUCCESS [01:48 
min]
    [INFO] flink-runtime-web .................................. SUCCESS [ 
28.635 s]
    [INFO] flink-examples ..................................... SUCCESS [  
3.177 s]
    [INFO] flink-examples-batch ............................... SUCCESS [01:09 
min]
    [INFO] flink-contrib ...................................... SUCCESS [  
0.847 s]
    [INFO] flink-statebackend-rocksdb ......................... SUCCESS [ 
11.992 s]
    [INFO] flink-tests ........................................ SUCCESS [03:27 
min]
    [INFO] flink-streaming-scala .............................. SUCCESS [01:21 
min]
    [INFO] flink-streaming-connectors ......................... SUCCESS [  
0.532 s]
    [INFO] flink-connector-flume .............................. SUCCESS [  
8.794 s]
    [INFO] flink-libraries .................................... SUCCESS [  
0.285 s]
    [INFO] flink-table ........................................ SUCCESS [02:22 
min]
    [INFO] flink-metrics-jmx .................................. SUCCESS [  
6.208 s]
    [INFO] flink-connector-kafka-base ......................... SUCCESS [ 
14.832 s]
    [INFO] flink-connector-kafka-0.8 .......................... SUCCESS [ 
10.985 s]
    [INFO] flink-connector-kafka-0.9 .......................... SUCCESS [  
7.464 s]
    [INFO] flink-connector-elasticsearch ...................... SUCCESS [ 
11.186 s]
    [INFO] flink-connector-elasticsearch2 ..................... SUCCESS [ 
11.327 s]
    [INFO] flink-connector-rabbitmq ........................... SUCCESS [  
5.484 s]
    [INFO] flink-connector-twitter ............................ SUCCESS [  
6.641 s]
    [INFO] flink-connector-nifi ............................... SUCCESS [  
6.188 s]
    [INFO] flink-connector-cassandra .......................... SUCCESS [ 
11.955 s]
    [INFO] flink-connector-redis .............................. SUCCESS [  
7.246 s]
    [INFO] flink-connector-filesystem ......................... SUCCESS [  
8.218 s]
    [INFO] flink-batch-connectors ............................. SUCCESS [  
0.283 s]
    [INFO] flink-avro ......................................... SUCCESS [  
9.166 s]
    [INFO] flink-jdbc ......................................... SUCCESS [  
7.117 s]
    [INFO] flink-hadoop-compatibility ......................... SUCCESS [  
9.769 s]
    [INFO] flink-hbase ........................................ SUCCESS [  
8.976 s]
    [INFO] flink-hcatalog ..................................... SUCCESS [ 
15.990 s]
    [INFO] flink-examples-streaming ........................... SUCCESS [ 
35.892 s]
    [INFO] flink-gelly ........................................ SUCCESS [ 
21.147 s]
    [INFO] flink-gelly-scala .................................. SUCCESS [ 
35.202 s]
    [INFO] flink-gelly-examples ............................... SUCCESS [ 
31.837 s]
    [INFO] flink-python ....................................... SUCCESS [  
8.998 s]
    [INFO] flink-ml ........................................... SUCCESS [02:34 
min]
    [INFO] flink-cep .......................................... SUCCESS [ 
21.447 s]
    [INFO] flink-cep-scala .................................... SUCCESS [ 
46.998 s]
    [INFO] flink-scala-shell .................................. SUCCESS [ 
50.330 s]
    [INFO] flink-quickstart ................................... SUCCESS [  
4.723 s]
    [INFO] flink-quickstart-java .............................. SUCCESS [  
2.686 s]
    [INFO] flink-quickstart-scala ............................. SUCCESS [  
0.957 s]
    [INFO] flink-storm ........................................ SUCCESS [ 
24.464 s]
    [INFO] flink-storm-examples ............................... SUCCESS [03:51 
min]
    [INFO] flink-streaming-contrib ............................ SUCCESS [ 
18.222 s]
    [INFO] flink-tweet-inputformat ............................ SUCCESS [  
9.515 s]
    [INFO] flink-operator-stats ............................... SUCCESS [  
8.018 s]
    [INFO] flink-connector-wikiedits .......................... SUCCESS [  
6.316 s]
    [INFO] flink-yarn ......................................... SUCCESS [ 
26.015 s]
    [INFO] flink-dist ......................................... SUCCESS [01:04 
min]
    [INFO] flink-metrics-dropwizard ........................... SUCCESS [  
8.947 s]
    [INFO] flink-metrics-ganglia .............................. SUCCESS [  
5.176 s]
    [INFO] flink-metrics-graphite ............................. SUCCESS [  
4.891 s]
    [INFO] flink-metrics-statsd ............................... SUCCESS [  
7.830 s]
    [INFO] flink-fs-tests ..................................... SUCCESS [  
3.448 s]
    [INFO] flink-java8 ........................................ SUCCESS [ 
14.214 s]
    [INFO] 
------------------------------------------------------------------------
    [INFO] BUILD SUCCESS
    [INFO] 
------------------------------------------------------------------------
    [INFO] Total time: 39:09 min
    `


> Rename "recovery.mode" config key to "high-availability"
> --------------------------------------------------------
>
>                 Key: FLINK-4253
>                 URL: https://issues.apache.org/jira/browse/FLINK-4253
>             Project: Flink
>          Issue Type: Improvement
>            Reporter: Ufuk Celebi
>            Assignee: ramkrishna.s.vasudevan
>
> Currently, HA is configured via the following configuration keys:
> {code}
> recovery.mode: STANDALONE // No high availability (HA)
> recovery.mode: ZOOKEEPER // HA
> {code}
> This could be more straight forward by simply renaming the key to 
> {{high-availability}}. Furthermore, the term {{STANDALONE}} is overloaded. We 
> already have standalone cluster mode.
> {code}
> high-availability: NONE // No HA
> high-availability: ZOOKEEPER // HA via ZooKeeper
> {code}
> The {{recovery.mode}} configuration keys would have to be deprecated before 
> completely removing them.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to