[
https://issues.apache.org/jira/browse/FLINK-4253?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15418349#comment-15418349
]
ASF GitHub Bot commented on FLINK-4253:
---------------------------------------
Github user ramkrish86 commented on the issue:
https://github.com/apache/flink/pull/2342
> Can you add such a test?
Sure I can. The existing test cases helped to ensure that if there are no
old configs we are able to fetch from the new config. I can add a test case to
ensure both the configs are accepted.
> The other variables should match, e.g.
recovery.jobmanager.port => high-availability.jobmanager.port and also
recovery.zookeeper.* => recovery.zookeeper.* etc.
I see. I had this doubt but since the PR was talking about this specific
param I thought that would be enough. +1 to change all relevant ones. I can
update it in the next PR.
Thanks all for the comments.
> Rename "recovery.mode" config key to "high-availability"
> --------------------------------------------------------
>
> Key: FLINK-4253
> URL: https://issues.apache.org/jira/browse/FLINK-4253
> Project: Flink
> Issue Type: Improvement
> Reporter: Ufuk Celebi
> Assignee: ramkrishna.s.vasudevan
>
> Currently, HA is configured via the following configuration keys:
> {code}
> recovery.mode: STANDALONE // No high availability (HA)
> recovery.mode: ZOOKEEPER // HA
> {code}
> This could be more straight forward by simply renaming the key to
> {{high-availability}}. Furthermore, the term {{STANDALONE}} is overloaded. We
> already have standalone cluster mode.
> {code}
> high-availability: NONE // No HA
> high-availability: ZOOKEEPER // HA via ZooKeeper
> {code}
> The {{recovery.mode}} configuration keys would have to be deprecated before
> completely removing them.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
