dmvk commented on a change in pull request #18651:
URL: https://github.com/apache/flink/pull/18651#discussion_r803580523



##########
File path: 
flink-connectors/flink-connector-base/src/main/java/org/apache/flink/connector/base/sink/writer/AsyncSinkWriter.java
##########
@@ -267,18 +267,31 @@ private void registerCallback() {
 
     @Override
     public void write(InputT element, Context context) throws IOException, 
InterruptedException {
+        while (mailboxExecutor.tryYield()) {}

Review comment:
       @dannycranmer It sounds fishy and doesn't align with the quality 
standards we require for Flink contributions. If you're concerned about the 
feature freeze, this can still be merged after that as the current 
implementation is broken.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to