dmvk commented on a change in pull request #18651:
URL: https://github.com/apache/flink/pull/18651#discussion_r803594934



##########
File path: 
flink-connectors/flink-connector-base/src/main/java/org/apache/flink/connector/base/sink/writer/AsyncSinkWriter.java
##########
@@ -267,18 +267,31 @@ private void registerCallback() {
 
     @Override
     public void write(InputT element, Context context) throws IOException, 
InterruptedException {
+        while (mailboxExecutor.tryYield()) {}

Review comment:
       I'm not saying there is an issue. I just don't feel comfortable saying 
there is not, and if Piotr is not comfortable with that on the first sight as 
well, it's worth giving it a closer look. Unfortunately I don't have enough 
context in this area to provide more insight myself.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to