gaoyunhaii commented on a change in pull request #18680: URL: https://github.com/apache/flink/pull/18680#discussion_r804316721
########## File path: flink-connectors/flink-connector-files/src/main/java/org/apache/flink/connector/file/sink/compactor/FileCompactStrategy.java ########## @@ -0,0 +1,105 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.connector.file.sink.compactor; + +import org.apache.flink.connector.file.sink.FileSink; + +import java.io.Serializable; + +import static org.apache.flink.util.Preconditions.checkArgument; + +/** Strategy for compacting the files written in {@link FileSink} before committing. */ +public class FileCompactStrategy implements Serializable { + + private static final long serialVersionUID = 1L; + + // Compaction triggering strategies. + private final long sizeThreshold; + private final boolean compactOnCheckpoint; + + // Compaction executing strategies. + private final int compactThread; + + private FileCompactStrategy( + long sizeThreshold, boolean compactOnCheckpoint, int compactThread) { + this.sizeThreshold = sizeThreshold; + this.compactOnCheckpoint = compactOnCheckpoint; + this.compactThread = compactThread; + } + + public long getSizeThreshold() { + return sizeThreshold; + } + + public boolean isCompactOnCheckpoint() { Review comment: If possible we might support compact for each `n` checkpoints. ########## File path: flink-connectors/flink-connector-files/src/main/java/org/apache/flink/connector/file/sink/compactor/ConcatFileCompactor.java ########## @@ -0,0 +1,70 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.connector.file.sink.compactor; + +import org.apache.flink.core.fs.FSDataInputStream; +import org.apache.flink.core.fs.FileSystem; +import org.apache.flink.core.fs.Path; + +import javax.annotation.Nullable; + +import java.io.IOException; +import java.io.InputStream; +import java.io.OutputStream; +import java.util.List; + +/** + * A {@link OutputStreamBasedFileCompactor} implementation that simply concat the compacting files. + * The fileDelimiter will be added between neighbouring files if provided. + */ +public class ConcatFileCompactor extends OutputStreamBasedFileCompactor { + + private static final int CHUNK_SIZE = 4 * 1024 * 1024; + + private final byte[] fileDelimiter; + + public ConcatFileCompactor() { Review comment: This method is not used? ########## File path: flink-connectors/flink-connector-files/src/main/java/org/apache/flink/connector/file/sink/compactor/OutputStreamBasedFileCompactor.java ########## @@ -0,0 +1,85 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.connector.file.sink.compactor; + +import org.apache.flink.core.fs.Path; +import org.apache.flink.streaming.api.functions.sink.filesystem.CompactingFileWriter; +import org.apache.flink.streaming.api.functions.sink.filesystem.OutputStreamBasedCompactingFileWriter; + +import java.io.IOException; +import java.io.OutputStream; +import java.util.List; + +/** + * Base class for {@link FileCompactor} implementations that use the {@link + * OutputStreamBasedCompactingFileWriter}. + */ +public abstract class OutputStreamBasedFileCompactor implements FileCompactor { + @Override + public final CompactingFileWriter.Type getWriterType() { + return CompactingFileWriter.Type.OUTPUT_STREAM; + } + + @Override + public void compact(List<Path> inputFiles, CompactingFileWriter writer) throws Exception { + // The outputStream returned by OutputStreamBasedCompactingFileWriter#asOutputStream should + // not be closed here. + CloseShieldOutputStream outputStream = + new CloseShieldOutputStream( + ((OutputStreamBasedCompactingFileWriter) writer).asOutputStream()); + doCompact(inputFiles, outputStream); + } + + protected abstract void doCompact(List<Path> inputFiles, OutputStream outputStream) + throws Exception; + + // A utility class to prevent the enclosing OutputStream being closed. + private static class CloseShieldOutputStream extends OutputStream { Review comment: There is already a class `CloseShieldOutputStream`, could you move this to a public position and reuse across the two positions? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
