gaoyunhaii commented on a change in pull request #18680: URL: https://github.com/apache/flink/pull/18680#discussion_r804323075
########## File path: flink-connectors/flink-file-sink-common/src/main/java/org/apache/flink/streaming/api/functions/sink/filesystem/BucketWriter.java ########## @@ -39,6 +39,32 @@ InProgressFileWriter<IN, BucketID> openNewInProgressFile( final BucketID bucketID, final Path path, final long creationTime) throws IOException; + /** + * Used to create a new {@link CompactingFileWriter} of the requesting type. A {@link + * InProgressFileWriter} will be created by default, which supports only the RECORD_WISE type. + * Requesting a writer of an unsupported type will result in an UnsupportedOperationException. Review comment: I think it is ok. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org