zentol commented on a change in pull request #18692: URL: https://github.com/apache/flink/pull/18692#discussion_r804549715
########## File path: flink-filesystems/flink-s3-fs-base/pom.xml ########## @@ -235,6 +265,27 @@ under the License. <skip>true</skip> </configuration> </plugin> + + <plugin> + <groupId>org.apache.maven.plugins</groupId> + <artifactId>maven-jar-plugin</artifactId> + <inherited>true</inherited> + <configuration> + <archive> + <manifest> + <addDefaultImplementationEntries>true</addDefaultImplementationEntries> + <addDefaultSpecificationEntries>true</addDefaultSpecificationEntries> + </manifest> + </archive> + </configuration> Review comment: ```suggestion ``` What is all this for? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org