tsreaper commented on a change in pull request #18822:
URL: https://github.com/apache/flink/pull/18822#discussion_r810878620



##########
File path: 
flink-connectors/flink-connector-jdbc/src/main/java/org/apache/flink/connector/jdbc/internal/JdbcOutputFormat.java
##########
@@ -154,7 +154,9 @@ public void open(int taskNumber, int numTasks) throws 
IOException {
                                         try {
                                             flush();
                                         } catch (Exception e) {
-                                            flushException = e;
+                                            if (flushException == null) {

Review comment:
       This does not solve the chaining exception problem. We'll still get a 
lot of suppressed `RuntimeException`s.
   
   If we need to store all exceptions and avoid this problem we'll need a 
special exception class so that when we catch this exception class in timer we 
just ignore it.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to