FilKarnicki commented on a change in pull request #307:
URL: https://github.com/apache/flink-statefun/pull/307#discussion_r824543145
##########
File path:
statefun-flink/statefun-flink-core/src/main/java/org/apache/flink/statefun/flink/core/StatefulFunctionsJob.java
##########
@@ -36,18 +35,8 @@
private static final AtomicInteger FEEDBACK_INVOCATION_ID_SEQ = new
AtomicInteger();
public static void main(String... args) throws Exception {
- ParameterTool parameterTool = ParameterTool.fromArgs(args);
- Map<String, String> globalConfigurations = parameterTool.toMap();
-
- StreamExecutionEnvironment env =
StreamExecutionEnvironment.getExecutionEnvironment();
Review comment:
I'm worried that I won't be able to set (for example) checkpointing
intervals per job, unless I create the `StreamExecutionEnvironment` using job
args. Am I correct?
Knowing the subtleties of `getExecutionEnvironment`, do you think that using
args as parameters for `getExecutionEnvironment` only when 'statefun.embedded'
is 'true' is also too much of a change?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
