igalshilman commented on a change in pull request #307:
URL: https://github.com/apache/flink-statefun/pull/307#discussion_r824676050
##########
File path:
statefun-flink/statefun-flink-core/src/main/java/org/apache/flink/statefun/flink/core/StatefulFunctionsJob.java
##########
@@ -36,18 +35,8 @@
private static final AtomicInteger FEEDBACK_INVOCATION_ID_SEQ = new
AtomicInteger();
public static void main(String... args) throws Exception {
- ParameterTool parameterTool = ParameterTool.fromArgs(args);
- Map<String, String> globalConfigurations = parameterTool.toMap();
-
- StreamExecutionEnvironment env =
StreamExecutionEnvironment.getExecutionEnvironment();
Review comment:
I'm not sure that this is true, as far as I can tell, you should be able
to set the parallelism even without creating the env manually.
I think that[ this is the
place](https://github.com/apache/flink/blob/master/flink-clients/src/main/java/org/apache/flink/client/ClientUtils.java#L82)
where the magic happens in Flink, where the correct env is prepared and set as
thread local.
The best thing would be to simply try it out.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
