Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/2363#discussion_r75343567
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/metrics/MetricRegistry.java
---
@@ -207,6 +239,9 @@ public void register(Metric metric, String metricName,
MetricGroup group) {
}
}
}
+ if (queryService != null) {
+ notifyOfAddedMetric(queryService, metric,
metricName, (AbstractMetricGroup) group);
--- End diff --
I think it's always good practice to add the class whose static method on
calls in front of the static method. Otherwise you easily think that this
method is somewhere defined in this class. Consequently, I would discourage
static imports a little bit.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
