Github user tillrohrmann commented on a diff in the pull request:

    https://github.com/apache/flink/pull/2363#discussion_r75346843
  
    --- Diff: 
flink-runtime/src/main/scala/org/apache/flink/runtime/jobmanager/JobManager.scala
 ---
    @@ -1024,6 +1024,17 @@ class JobManager(
     
         case RequestWebMonitorPort =>
           sender() ! ResponseWebMonitorPort(webMonitorPort)
    +
    +    case MetricRequest =>
    +      metricsRegistry match {
    +        case Some(registry) =>
    +          registry.getQueryService match {
    +            case Some(queryService) =>
    +              queryService ! sender()
    +            case None =>
    +          }
    +        case None =>
    --- End diff --
    
    In both `None` cases you should return a failure message to the sender so 
that it does not have to wait until the future times out.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to