XComp commented on code in PR #19275:
URL: https://github.com/apache/flink/pull/19275#discussion_r848128604
##########
flink-runtime/src/test/java/org/apache/flink/runtime/dispatcher/DispatcherTest.java:
##########
@@ -421,6 +421,8 @@ public void
testCancellationOfCanceledTerminalDoesNotThrowException() throws Exc
// wait for job to finish
dispatcherGateway.requestJobResult(jobId, TIMEOUT).get();
+ dispatcher.getJobTerminationFuture(jobId, TIMEOUT).get();
Review Comment:
It took me a bit to figure out why we need this change. It's related to [my
comment](https://github.com/apache/flink/pull/19275#discussion_r848126499)
about the `thenComposeAsync` which you added in `Dispatcher.runJob` to run the
`Dispatcher#removeJob` method in the main thread. I commented on that one
separatly. But we could revert this change if we agree that it's not necessary.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
