[GitHub] [flink] XComp commented on a diff in pull request #19275: [FLINK-24491][runtime] Make the job termination wait until the archiving of ExecutionGraphInfo finishes

[GitBox]

XComp commented on code in PR #19275:
URL: https://github.com/apache/flink/pull/19275#discussion_r848138048


##########
flink-runtime/src/main/java/org/apache/flink/runtime/dispatcher/Dispatcher.java:
##########
@@ -1215,17 +1244,23 @@ private CompletableFuture<Void> waitForTerminatingJob(
                 getMainThreadExecutor());
     }
 
-    CompletableFuture<Void> getJobTerminationFuture(JobID jobId) {
+    private CompletableFuture<Void> 
getJobTerminationFutureOrFailedFutureForRunningJob(

Review Comment:
   We could get rid of that change as well if we change the `thenComposeAsync` 
change in `Dispatcher#runJob`, I guess? This is also related to [my comment 
further up](https://github.com/apache/flink/pull/19275#discussion_r848126499).



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org