masteryhx commented on code in PR #19598:
URL: https://github.com/apache/flink/pull/19598#discussion_r860807435


##########
flink-state-backends/flink-statebackend-changelog/src/main/java/org/apache/flink/state/changelog/ChangelogKeyedStateBackend.java:
##########
@@ -694,6 +705,10 @@ public KeyedStateBackend<K> 
getDelegatedKeyedStateBackend(boolean recursive) {
         return keyedStateBackend.getDelegatedKeyedStateBackend(recursive);
     }
 
+    public ChangelogMetricGroup getMetrics() {
+        return metrics;
+    }

Review Comment:
   > the backend would only need report these sizes; and Materializer - events, 
such as started/completed/failed materialization.
   
   Maybe I could move completed into materialization part, but the precise 
place about starting materilization is `initMaterialization` where I report 
currently (From starting sync materlization on).
    
   Or maybe we could just report started before `initMaterialization` even if 
it doesn't have done a real materilization ?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to