rkhachatryan commented on code in PR #19598:
URL: https://github.com/apache/flink/pull/19598#discussion_r860931294
##########
flink-state-backends/flink-statebackend-changelog/src/main/java/org/apache/flink/state/changelog/ChangelogKeyedStateBackend.java:
##########
@@ -694,6 +705,10 @@ public KeyedStateBackend<K>
getDelegatedKeyedStateBackend(boolean recursive) {
return keyedStateBackend.getDelegatedKeyedStateBackend(recursive);
}
+ public ChangelogMetricGroup getMetrics() {
+ return metrics;
+ }
Review Comment:
If I understand correctly, you are talking about where to call
`reportPendingMaterialization()`:
`ChangelogKeyedStateBackend.initMaterialization` or
`PeriodicMaterializationManager.triggerMaterialization`.
I think it doesn't matter much in terms of usefulness (on one hand, it might
be useful to know whether the materialization was scheduled or not at all; OTH,
`mailboxExecutor` might delay it after triggering).
So I think the latter (from `PeriodicMaterializationManager`) is fine.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
