FuyaoLi2017 commented on PR #202: URL: https://github.com/apache/flink-kubernetes-operator/pull/202#issuecomment-1126402997
Hi @Aitozi @gyfora , thanks for reviewing this. I have updated the code based on your suggestions. 1. Update typos for `spec.job.flinkConfiguration`. 2. Update documentation about the session job flink configuration and provided allowed configurations (only the header config at the moment). 3. Add validator logic in `DefaultValidator`. Also refactored existing `validateFlinkConfig` method name to `validateFlinkDeploymentConfig` to avoid confusion. 4. Move configuration merge logic into `FlinkConfigManager`. Add a `getSessionJobObserveConfig` method, refactor a few places to call this method instead of `getObserveConfig`. There were some merge conflicts and rebased the main branch. I ran into some errors and introduced some unexpected changes, as a result, I force pushed the code to make it clean. Sorry for making the commit history kind of messy.. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org