FuyaoLi2017 commented on code in PR #202: URL: https://github.com/apache/flink-kubernetes-operator/pull/202#discussion_r872863534
########## flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/artifact/FileSystemBasedArtifactFetcher.java: ########## @@ -33,7 +34,8 @@ public class FileSystemBasedArtifactFetcher implements ArtifactFetcher { new FileSystemBasedArtifactFetcher(); @Override - public File fetch(String uri, File targetDir) throws Exception { + public File fetch(String uri, Configuration flinkConfiguration, File targetDir) Review Comment: No, it is not used. I need to change this line since this class overrides the `artifactFetcher` interface. In the future, we might need this configuration? Not sure. Anyways, it doesn't hurt. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org