1996fanrui commented on code in PR #19723:
URL: https://github.com/apache/flink/pull/19723#discussion_r876901555
##########
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/SubtaskCheckpointCoordinatorImpl.java:
##########
@@ -103,6 +112,14 @@ class SubtaskCheckpointCoordinatorImpl implements
SubtaskCheckpointCoordinator {
@GuardedBy("lock")
private boolean closed;
+ private final BiFunction<Callable<?>, Duration, Cancellable> registerTimer;
+
+ private final Clock clock;
+
+ /** Hold the AlignmentTimer for each checkpointId. */
+ @GuardedBy("lock")
Review Comment:
Thanks for your reminder, I checked that the
`SubtaskCheckpointCoordinatorImpl#close()` isn't called in anywhere. So can I
delete the close method in this PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
