[GitHub] [flink] 1996fanrui commented on a diff in pull request #19723: [FLINK-27251][checkpoint] Timeout aligned to unaligned checkpoint barrier in the output buffers

[GitBox]

1996fanrui commented on code in PR #19723:
URL: https://github.com/apache/flink/pull/19723#discussion_r879558979


##########
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/SubtaskCheckpointCoordinatorImpl.java:
##########
@@ -234,6 +265,11 @@ public void abortCheckpointOnBarrier(
                 () -> operatorChain.broadcastEvent(new 
CancelCheckpointMarker(checkpointId)));

Review Comment:
   Hi @pnowojski , thanks for your review again. I have another question.
   
   Currently, cancelAlignmentTimer should be called in TaskThread. Should we 
move these 4 lines into runThrowing? Like this:
   ```java
   actionExecutor.runThrowing(
           () -> {
               operatorChain.abortCheckpoint(checkpointId, cause);
               if (alignmentTimer != null && checkpointId == 
alignmentCheckpointId) {
                   cancelAlignmentTimer();
               }
               operatorChain.broadcastEvent(new 
CancelCheckpointMarker(checkpointId));
           });
   ``` 
   
   And should we call cancelAlignmentTimer(); in close method? In 
[FLINK-27724](https://issues.apache.org/jira/browse/FLINK-27724), I will fix 
the bug.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org