libenchao commented on code in PR #14376: URL: https://github.com/apache/flink/pull/14376#discussion_r906951970
########## flink-formats/flink-protobuf/src/main/java/org/apache/flink/formats/protobuf/serialize/PbRowDataSerializationSchema.java: ########## @@ -0,0 +1,74 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.formats.protobuf.serialize; + +import org.apache.flink.api.common.serialization.SerializationSchema; +import org.apache.flink.formats.protobuf.PbCodegenException; +import org.apache.flink.formats.protobuf.PbFormatConfig; +import org.apache.flink.formats.protobuf.PbFormatUtils; +import org.apache.flink.formats.protobuf.PbSchemaValidator; +import org.apache.flink.table.data.RowData; +import org.apache.flink.table.types.logical.RowType; +import org.apache.flink.util.FlinkRuntimeException; + +import com.google.protobuf.Descriptors; + +/** + * Serialization schema from Flink to Protobuf types. + * + * <p>Serializes a {@link RowData } to protobuf binary data. + * + * <p>Failures during deserialization are forwarded as wrapped {@link FlinkRuntimeException}. + */ +public class PbRowDataSerializationSchema implements SerializationSchema<RowData> { + + private final RowType rowType; + + private final PbFormatConfig pbFormatConfig; + + private transient RowToProtoConverter rowToProtoConverter; + + public PbRowDataSerializationSchema(RowType rowType, PbFormatConfig pbFormatConfig) { + this.rowType = rowType; + this.pbFormatConfig = pbFormatConfig; + Descriptors.Descriptor descriptor = + PbFormatUtils.getDescriptor(pbFormatConfig.getMessageClassName()); + new PbSchemaValidator(descriptor, rowType).validate(); + try { + // validate converter in client side to early detect errors + rowToProtoConverter = new RowToProtoConverter(rowType, pbFormatConfig); Review Comment: > The constructor of RowToProtoConverter will compile the generated java code and check if there's any exception. Does this mean that these kind of errors all belong to the implementation errors? In another word, if this happens, usually it's not caused by user configuration, but is caused the implementation flaw? If this is the case, I think we do not need to eagerly detect it since it should be a very rare case. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
