libenchao commented on code in PR #14376: URL: https://github.com/apache/flink/pull/14376#discussion_r907059256
########## flink-formats/flink-protobuf/src/main/java/org/apache/flink/formats/protobuf/PbCodegenAppender.java: ########## @@ -0,0 +1,58 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.formats.protobuf; + +/** Helper class which do code fragment concat. */ +public class PbCodegenAppender { + private StringBuilder sb; + + public PbCodegenAppender() { Review Comment: @maosuhan I prototyped the indent support in this commit: https://github.com/libenchao/flink/commit/55b9d3a707ed9f046f3b44bb17d88453d063be0b, please take a look. Besides the indent, I also did some minor changes: - move `PbCodegenAppender`/`PbCodegenVarId`/`PbSchemaValidatorUtils` to `util` package - improve several raw usages for generic types - make `private` for some methods If you agree with this approach, you can cherry-pick the commit to your branch and do the next steps. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
