[ 
https://issues.apache.org/jira/browse/FLINK-4538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15465028#comment-15465028
 ] 

ASF GitHub Bot commented on FLINK-4538:
---------------------------------------

Github user tillrohrmann commented on a diff in the pull request:

    https://github.com/apache/flink/pull/2463#discussion_r77523985
  
    --- Diff: 
flink-runtime/src/main/java/org/apache/flink/runtime/taskexecutor/TaskExecutorGateway.java
 ---
    @@ -32,4 +33,11 @@
        // 
------------------------------------------------------------------------
     
        void notifyOfNewResourceManagerLeader(String address, UUID 
resourceManagerLeaderId);
    +
    +   /**
    +    * Send by the ResourceManager to the TaskExecutor
    +    * @param allocationID id for the request
    +    * @param resourceManagerLeaderID current leader id of the 
ResourceManager
    +    */
    +   void requestSlot(AllocationID allocationID, UUID 
resourceManagerLeaderID);
    --- End diff --
    
    How is the confirmation of the `TaskExecutor` sent back to the 
`SlotManager`? Would it make sense to send it back via the return value of this 
method?


> Implement slot allocation protocol with JobMaster
> -------------------------------------------------
>
>                 Key: FLINK-4538
>                 URL: https://issues.apache.org/jira/browse/FLINK-4538
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Cluster Management
>            Reporter: Maximilian Michels
>            Assignee: Maximilian Michels
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to