[ 
https://issues.apache.org/jira/browse/FLINK-4538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15465037#comment-15465037
 ] 

ASF GitHub Bot commented on FLINK-4538:
---------------------------------------

Github user tillrohrmann commented on a diff in the pull request:

    https://github.com/apache/flink/pull/2463#discussion_r77524239
  
    --- Diff: 
flink-runtime/src/main/java/org/apache/flink/runtime/taskexecutor/SlotStatus.java
 ---
    @@ -46,13 +47,21 @@
        /** if the slot is allocated, jobId identify which job this slot is 
allocated to; else, jobId is null */
        private final JobID jobID;
     
    -   public SlotStatus(SlotID slotID, ResourceProfile profiler) {
    -           this(slotID, profiler, null, null);
    +   /** Gateway to the TaskManager which reported the SlotStatus */
    +   private final TaskExecutorGateway taskExecutorGateway;
    --- End diff --
    
    The `SlotStatus` is no longer serializable with this field. Where does the 
`SlotStatus` come from? If it's coming from the `TaskExecutor`, then the 
`taskExecutorGateway` has to be retrieved on the `ResourceManager` side.


> Implement slot allocation protocol with JobMaster
> -------------------------------------------------
>
>                 Key: FLINK-4538
>                 URL: https://issues.apache.org/jira/browse/FLINK-4538
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Cluster Management
>            Reporter: Maximilian Michels
>            Assignee: Maximilian Michels
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to