swuferhong commented on code in PR #20596: URL: https://github.com/apache/flink/pull/20596#discussion_r948962853
########## flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/plan/rules/physical/batch/DynamicPartitionPruningRuleTest.java: ########## @@ -410,21 +419,35 @@ public void testComplexDimSideWithAggInDimSide() { // --------------------------dpp factor test --------------------------------------------- @Test - public void testDPPFactorToReorderTable() { + public void testDPPFactorToReorderTableWithoutStats() { // While there are several joins, and fact table not adjacent to dim table directly. dynamic // partition pruning factor will try best to reorder join relations to make fact table // adjacent to dim table. - String ddl1 = - "CREATE TABLE test_database.sales (\n" + String ddl2 = Review Comment: > nit: ddl2 -> ddl ? Done! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org